Open
Conversation
Collaborator
|
Could you attach a screenshot or screen recording of what this looks like with the change? |
krugerk
force-pushed
the
tweak/quick-sort
branch
from
b2ef9af to
eab919a
Compare
theospears
approved these changes
Feb 1, 2026
Collaborator
theospears
left a comment
theospears
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I see this is marked as a draft, do you think it is ready to merge, or does it need more work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As is, the sorting preference of the gallery is located in a screen accessible from the settings screen. Urgency might be the sort order most commonly used (hypothesis) with recent data also making sense as a way to check which goals have recently been updated. Changing from to the other requires four taps and takes place across three screens.
This Merge Request proposes offering changing the sorting preference of the gallery while still at the gallery. It reduces the taps from four to two.
For UI changes including screenshots of before and after is great.
Validation
Ran app in simulator.
Sorted the gallery.