show when healthkit linked goal was last synced with healthkit#601
show when healthkit linked goal was last synced with healthkit#601krugerk wants to merge 1 commit intobeeminder:masterfrom
Conversation
BeeSwift/GoalViewController.swift
Outdated
|
|
||
| private func refreshPullDown() { | ||
| let dateFormatter = ISO8601DateFormatter() | ||
| dateFormatter.formatOptions = [.withFullDate, .withFullTime] |
|
Proposal: strip that down to nothing but HH:MM -- no date, no seconds, no am/pm, no timezone, nothing. I would've thought that too extreme but it's what Stripe does on their mobile app and I realized it works because you figure it out by experimentation. |
krugerk
force-pushed
the
feature/when-was-goal-last-synced-with-apple-health
branch
from
26eb85c to
c2374bb
Compare
updated to show date too (in user's preferred format) when last sync was not in the same day and to show the time in the user's preferred format |
| <attribute name="id" attributeType="String"/> | ||
| <attribute name="initDay" attributeType="Integer 64" defaultValueString="0" usesScalarValueType="YES"/> | ||
| <attribute name="lastModifiedLocal" optional="YES" attributeType="Date" usesScalarValueType="NO"/> | ||
| <attribute name="lastSyncedWithHealthKit" optional="YES" attributeType="Date" usesScalarValueType="NO"/> |
There was a problem hiding this comment.
The convention for the app is for attributes which are not synced from the server to have names ending in ...Local. Could you update this and also add to the newest data model version rather than the base one now there are multiple?
krugerk
force-pushed
the
feature/when-was-goal-last-synced-with-apple-health
branch
2 times, most recently
from
56355b0 to
7c8ca7c
Compare
krugerk
force-pushed
the
feature/when-was-goal-last-synced-with-apple-health
branch
from
7c8ca7c to
cec1769
Compare
| /// This does mean users who have very little buffer, and are not regularly unlocking their phone, may erroneously derail. There is nothing we | ||
| /// can do about this. | ||
| static let daysToUpdateOnChangeNotification = 7 | ||
|
|
There was a problem hiding this comment.
Any idea where all these whitespace changes came from? I would have guessed swift format, but I've confirmed this doesn't happen for me when I trigger reformatting of this file.
There was a problem hiding this comment.
No I am not sure and I noticed too and have not looked into it further, yet.
|
Still marked as draft because as is a goalVC will not update as the goal does to show the more recent last synced time. It just shows it as it was when the gaolVC was opened. |
3 participants
Summary
The user can see the most recent datapoints and can infer from that when the last sync took place. This PR displays the date directly so the user need not infer when that might have been.
For UI changes including screenshots of before and after is great.
when synced today
showing time
previous
showing the full date/time
Validation
ran app in simulator
Tickets
Fixes #193