test of goalvc / add data initial stepper value#529
Draft
krugerk wants to merge 7 commits intobeeminder:masterfrom
Draft
test of goalvc / add data initial stepper value#529krugerk wants to merge 7 commits intobeeminder:masterfrom
krugerk wants to merge 7 commits intobeeminder:masterfrom
Conversation
theospears
reviewed
Nov 25, 2024
krugerk
force-pushed
the
bugfix/stepper-starts-with-wrong-value
branch
from
6cb6310 to
fe60c20
Compare
Collaborator
|
What's your plan here? I still think we should add tests for this logic, using old-style tests if necessary. |
Contributor
Author
Ah, I was cleaning up branches when I deleted this one which in turn closed this draft PR. |
back to xctestcase for now
krugerk
force-pushed
the
bugfix/stepper-starts-with-wrong-value
branch
from
85e93a7 to
9b56b35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to test the logic for calculating the date initially shown in the add data section of a goal, a small goalVM has been introduced for the goalVC.
#528 (comment)