Conversation
byubean
reviewed
Apr 21, 2025
src/quest/external.py
Outdated
| await wrapper.__aexit__(exc_type, exc_val, exc_tb) | ||
| # Exit all queues properly - suspended | ||
| for ident, wrapper in list(self.queues.items()): | ||
| await wrapper.__aexit__(asyncio.CancelledError, asyncio.CancelledError(SUSPENDED), None) |
byubean
reviewed
Apr 21, 2025
src/quest/external.py
Outdated
Comment on lines
+153
to
+161
| # If identity is still active, cancel and clean up | ||
| if ident in self.ident_to_task: | ||
| task = self.ident_to_task[ident] | ||
| del self.ident_to_task[ident] | ||
| del self.task_to_ident[task] | ||
| task.cancel() | ||
|
|
||
| # Call __aexit__ on the corresponding queue wrapper | ||
| wrapper = self.queues.pop(ident, None) | ||
| if wrapper: | ||
| await wrapper.__aexit__(None, None, None) | ||
| wrapper = self.queues.pop(ident) | ||
| await wrapper.__aexit__(asyncio.CancelledError, asyncio.CancelledError(SUSPENDED), None) |
Collaborator
There was a problem hiding this comment.
if ident not in self.ident_to_task:
raise Exception()await wrapper.__aexit__(None, None, None)
byubean
reviewed
Apr 21, 2025
quest_test/test_external_actions.py
Outdated
Comment on lines
+317
to
+320
| # Both p1 and p2 have a chat | ||
| assert ('chat', 'p1') in await find_historian().get_resources('p1') | ||
| assert ('chat', 'p2') in await find_historian().get_resources('p2') | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.