Open
Conversation
byubean
reviewed
Apr 4, 2025
history_test/test_basic.py
Outdated
| async def test_basic_workflow(): | ||
| history = [] | ||
| historian = Historian( | ||
| historian = History( |
Collaborator
There was a problem hiding this comment.
we should probably rename these historians and historys
byubean
reviewed
Apr 4, 2025
history_test/test_context.py
Outdated
| """import pytest | ||
|
|
||
| from src.quest import these | ||
| from src.history import these |
Collaborator
There was a problem hiding this comment.
This shouldn't be importing from src. Let's fix it while we are here.
Contributor
Author
There was a problem hiding this comment.
test_context.py is commented out? Is that on purpose?
byubean
reviewed
Apr 4, 2025
| manager = find_workflow_manager() | ||
| workflow_id = find_historian().workflow_id | ||
| manager = find_historian() | ||
| workflow_id = find_history().workflow_id |
Collaborator
There was a problem hiding this comment.
is workflow_id still good terminology?
Contributor
Author
There was a problem hiding this comment.
I think story is good for the theme, I wonder if it is obvious to the user what its function is?
byubean
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other renames for simplicity and theme