cherry-pick patch to fix assembler errors#6
Open
1480c1 wants to merge 1 commit intobcoudurier:ffmbcfrom
Open
Conversation
…in inline assembly Fixes assembling with binutil as >= 2.41 Signed-off-by: James Almer <jamrial@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes assembler errors that occur with binutils >= 2.41 by updating inline assembly constraints in x86-specific math operations. The changes distinguish between compile-time constant shift values and runtime shift values, using appropriate assembly constraints for each case.
Changes:
- Added runtime checks using
__builtin_constant_p()to differentiate between constant and variable shift amounts - Updated assembly constraints: using "i" constraint with mask for constants, and "c" constraint for runtime variables
- Applied the fix to three functions:
MULL,NEG_SSR32, andNEG_USR32
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes assembling with binutil as >= 2.41