Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #38
Adds table to PDFPreview to display all crawl instances a PDF has been scraped. If there are more than 5, then it collapses the list by default. Front end remains backwards compatible with existing server API.
/preview (before and after)
A new config argument adds a hard cap on the number of crawls returned by the API. Default is 500, shown here, demonstrated here at 1. If there are more than the cap returned, then the API sets a flag in the response so the UI knows to add the message.
Adds every crawl instances to a new response field on the backend's search and pages APIs. The original response fields are retained for the most recent crawl for backwards compatibility.