Skip to content

Removes/replaces remaining references to sample_count and sample_offset#180

Open
j616 wants to merge 4 commits intomainfrom
jamessa-objectTr
Open

Removes/replaces remaining references to sample_count and sample_offset#180
j616 wants to merge 4 commits intomainfrom
jamessa-objectTr

Conversation

@j616
Copy link
Copy Markdown
Contributor

@j616 j616 commented Mar 19, 2026

Details

sample_count and sample_offset were deprecated in TAMS v8.0, with the change being introduced in #147 . This PR removes lingering references to those parameters, and updates example scripts to instead use object_timerange

Jira Issue (if relevant)

Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5514

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner March 19, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant