Open
Conversation
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Some tools in rules_cc like gcov and llvm-cov, expect absolute paths in the toolchain. This clearly isn't ideal but updating all callers as a blocker to being able to use rules based toolchains also isn't ideal. This allows backfilling those absolute tool paths with the new cc_legacy_tool rule.
keith
force-pushed
the
ks/add-cc_legacy_tool-stopgap
branch
from
bbd61dc to
a1da7d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tools in rules_cc like gcov and llvm-cov, expect absolute paths in
the toolchain. This clearly isn't ideal but updating all callers as a
blocker to being able to use rules based toolchains also isn't ideal.
This allows backfilling those absolute tool paths with the new
cc_legacy_tool rule.