Added regression testing for bzl_library trees#661
Open
UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
Open
Added regression testing for bzl_library trees#661UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
Conversation
UebelAndre
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Contributor
Author
|
This is a revival of #482 |
trybka
reviewed
Mar 25, 2026
| "defs.bzl", | ||
| "action_names.bzl", | ||
| "system_library.bzl", | ||
| "cc_binary.bzl", |
Collaborator
There was a problem hiding this comment.
do these need to be exported even though they are referenced via :core_rules?
Contributor
Author
There was a problem hiding this comment.
They need to be so the stardoc targets can reference the individual files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to
rules_cchave lead to breakages of thebzl_librarytargets where they no longer include the full dependency graph. This change fixes the missing dependencies and addsstardoctargets to serve a regression test going forward.closes #279