Open
Conversation
fmeum
reviewed
Mar 25, 2026
This implements another attribute on toolchain configuration for rules based toolchains. Turns out similar to compiler and cpu many places reference the `target_gnu_system_name` which comes from this attribute. I added support for makefile variable expansion on this since it's potentially derived from a rule, vs a hardcoded string. Examples: - https://github.com/bazelbuild/rules_apple/blob/eed702ea4b42dca3081a63bb6abd030878abcb6f/apple/internal/linking_support.bzl#L108 - https://github.com/GoogleCloudPlatform/google-auth-library-perl/blob/f776c0292561df92358a1f86af172651bdb3d8e5/protobuf/protobuf_release.bzl#L16 - https://github.com/JetBrains/android/blob/46bd55242aa52447b13489147ec37cfdcf7902cb/aswb/aspect/build_dependencies_cc_deps.bzl#L64 - https://github.com/protocolbuffers/protobuf-javascript/blob/291b4604a3f9624e0a6b51a1e100368d13f43822/protobuf_javascript_release.bzl#L19 - https://github.com/bazelbuild/intellij/blob/cef70399b849f5393455d30eb8c98e9a7e542624/aspect/intellij_info_impl.bzl#L459
keith
force-pushed
the
ks/pass-through-target_system_name
branch
from
272bf66 to
b467d9f
Compare
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements another attribute on toolchain configuration for rules
based toolchains. Turns out similar to compiler and cpu many places
reference the
target_gnu_system_namewhich comes from this attribute.I added support for makefile variable expansion on this since it's
potentially derived from a rule, vs a hardcoded string.
Examples: