Skip to content

Remove IGNORE_COVERAGE_COLLECTION_FAILURES from presubmit #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UebelAndre wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove IGNORE_COVERAGE_COLLECTION_FAILURES from presubmit #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ test_targets_bazel_6: &test_targets_bazel_6
- "-//tests/system_library:system_library_test" # Should be skipped on Windows and MacOS
- "-//tests/cc/common:test_runtime_dynamic_libraries_copy_behavior" # known bug, see https://github.com/bazelbuild/rules_cc/pull/623

common_coverage_flags: &common_coverage_flags
# Starting in Bazel 9 coverage collection causes some tests to fail.
# https://github.com/bazelbuild/rules_cc/issues/613
- "--test_env=IGNORE_COVERAGE_COLLECTION_FAILURES=1"
# Test failures are not collected under `coverage` invocations.
# https://github.com/bazelbuild/continuous-integration/issues/1838
- "--test_output=errors"

buildifier:
version: latest

Expand Down Expand Up @@ -100,22 +92,21 @@ tasks:
platform: macos
build_targets: *build_targets
test_targets: *test_targets
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets
macos_rolling:
name: MacOS (Bazel rolling)
bazel: rolling
platform: macos_arm64
build_targets: *build_targets
test_targets: *test_targets
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets
windows_rolling:
name: Windows (Bazel rolling)
bazel: rolling
platform: windows
build_targets: *build_targets
test_targets: *test_targets
coverage_targets: *test_targets

# Bazel 7
ubuntu2004_bazel_7:
Expand All @@ -124,30 +115,28 @@ tasks:
platform: ubuntu2004
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
macos_intel_bazel_7:
name: MacOS Intel (Bazel 7)
bazel: 7.x
platform: macos
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
macos_bazel_7:
name: MacOS (Bazel 7)
bazel: 7.x
platform: macos_arm64
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
windows_bazel_7:
name: Windows (Bazel 7)
bazel: 7.x
platform: windows
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_targets: *test_targets_bazel_6

# Bazel 8
ubuntu2004_bazel_8:
Expand All @@ -156,60 +145,56 @@ tasks:
platform: ubuntu2004
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
macos_intel_bazel_8:
name: MacOS Intel (Bazel 8)
bazel: 8.x
platform: macos
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
macos_bazel_8:
name: MacOS (Bazel 8)
bazel: 8.x
platform: macos_arm64
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets_bazel_6
windows_bazel_8:
name: Windows (Bazel 8)
bazel: 8.x
platform: windows
build_targets: *build_targets_bazel_6
test_targets: *test_targets_bazel_6
coverage_targets: *test_targets_bazel_6

# Bazel 9
ubuntu2004:
name: Ubuntu 20.04 (Bazel 9)
bazel: 9.x
build_targets: *build_targets
test_targets: *test_targets
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets
macos_intel:
name: MacOS Intel (Bazel 9)
bazel: 9.x
platform: macos
build_targets: *build_targets
test_targets: *test_targets
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets
macos:
name: MacOS (Bazel 9)
bazel: 9.x
platform: macos_arm64
build_targets: *build_targets
test_targets: *test_targets
coverage_flags: *common_coverage_flags
coverage_targets: *test_targets
windows:
name: Windows (Bazel 9)
bazel: 9.x
build_targets: *build_targets
test_targets: *test_targets
coverage_targets: *test_targets
ubuntu_bzlmod:
name: Ubuntu 20.04 (Bazel 9, bzlmod)
bazel: 9.x
Expand Down