Open
Conversation
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
keith
force-pushed
the
ks/add-default-objc_fully_link-config
branch
2 times, most recently
from
d8e41b8 to
cb38f50
Compare
keith
force-pushed
the
ks/add-default-objc_fully_link-config
branch
from
cb38f50 to
c7c6271
Compare
The objc-fully-link action looks very very similar to cpp_link_static_library. The only difference is a few variable names. This adds objc-fully-link to ar_actions, and sets up the default arguments for it. Users may want to add `-arch_only` but this is better than nothing.
keith
force-pushed
the
ks/add-default-objc_fully_link-config
branch
from
c7c6271 to
c846ef8
Compare
armandomontanez
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The objc-fully-link action looks very very similar to
cpp_link_static_library. The only difference is a few variable names.
This adds objc-fully-link to ar_actions, and sets up the default
arguments for it. Users may want to add
-arch_onlybut this is betterthan nothing.