Skip to content

[8.7.0] Make is_tool_configuration public (https://github.com/bazelbuild/bazel/pull/29056)#29105

Merged
iancha1992 merged 1 commit intobazelbuild:release-8.7.0from
bazel-io:cp29056-8.7.0-210432
Mar 27, 2026
Merged

[8.7.0] Make is_tool_configuration public (https://github.com/bazelbuild/bazel/pull/29056)#29105
iancha1992 merged 1 commit intobazelbuild:release-8.7.0from
bazel-io:cp29056-8.7.0-210432

Conversation

@bazel-io
Copy link
Copy Markdown
Member

This is a common ask from rules authors, most of whom check for -exec-
in ctx.bin_dir.path which is potentially fragile with path stripping.

Fixes #14444

Closes #29056.

PiperOrigin-RevId: 889280554
Change-Id: Id4380e59603513e5d6bee38de269057500ce6573

Commit 84c0253

This is a common ask from rules authors, most of whom check for `-exec-`
in `ctx.bin_dir.path` which is potentially fragile with path stripping.

Fixes bazelbuild#14444

Closes bazelbuild#29056.

PiperOrigin-RevId: 889280554
Change-Id: Id4380e59603513e5d6bee38de269057500ce6573
@bazel-io bazel-io requested a review from a team as a code owner March 25, 2026 21:05
@bazel-io bazel-io added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Mar 25, 2026
@bazel-io bazel-io requested review from gregestren and katre March 25, 2026 21:05
katre
katre previously approved these changes Mar 25, 2026
@iancha1992 iancha1992 enabled auto-merge March 25, 2026 21:19
@iancha1992 iancha1992 disabled auto-merge March 26, 2026 18:35
@iancha1992 iancha1992 dismissed katre’s stale review March 26, 2026 18:36

Greg needs to approve this

@iancha1992 iancha1992 enabled auto-merge March 26, 2026 18:36
@iancha1992 iancha1992 added this pull request to the merge queue Mar 27, 2026
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@iancha1992 iancha1992 added this pull request to the merge queue Mar 27, 2026
@iancha1992 iancha1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 27, 2026
Merged via the queue into bazelbuild:release-8.7.0 with commit 9aaa291 Mar 27, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants