Fixs the numbers mistake (BELL/CLIPBOARD) and padding mistake in Clipboard.write()#14
Open
andrews239 wants to merge 1 commit intobarneygale:mainfrom
Open
Fixs the numbers mistake (BELL/CLIPBOARD) and padding mistake in Clipboard.write()#14andrews239 wants to merge 1 commit intobarneygale:mainfrom
andrews239 wants to merge 1 commit intobarneygale:mainfrom
Conversation
…he padding misstake (Clipboard.write) for client -> server messages
|
Hi @barneygale, are there any plans to merge this PR anytime soon? asyncvnc is great, but I also just stumbled over this issue which causes constant crashes. |
jeffmcjunkin
added a commit
to RogueValleyInformationSecurity/asyncvnc
that referenced
this pull request
Jan 30, 2026
…nshot and Bell/Clipboard PR barneygale#11 (partial refresh fix): - Add Video.get_rect() for bounds validation - Update is_complete(x, y, width, height) to check ROI only - Update as_rgba(x, y, width, height) to return ROI only - Fix screenshot() to pass ROI to both methods This fixes the screenshot timeout issue where VMware's VNC server sends incremental updates after UI changes (like clicks), causing is_complete() to never return True when checking the entire buffer. PR barneygale#14 (Bell/Clipboard fix): - Fix UpdateType enum: BELL=2, CLIPBOARD=3 (was incorrectly swapped) - Fix Clipboard.write() padding: b'\x06\x00\x00\x00' (was b'\x06\x00') Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the numbers mistake (BELL/CLIPBOARD) for server -> client and the padding mistake (Clipboard.write) for client -> server messages.
See: #13
Fixes the test tests/test_clipboard.py for RFC-6143 compliance.