Open
Conversation
docker `COPY` was introducing files using root user, so hypnotoad was not able to create the PID files on `./script`
the base builddep stretch image comes with IPv6 disabled so morbo was failing to bind. So just using IPv4.
Collaborator
Author
|
The generated image on Dockerhub: https://hub.docker.com/r/barcelonapm/project-x/tags/ |
maneta
force-pushed
the
circle-ci
branch
2 times, most recently
from
a031fcd to
4116c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: TO MERGE THIS WE WILL NEED TO CONFIGURE CIRCLE CI FIRST
In this PR we introduce:
entrypointscript.CircleCI JOB
This Job run the tests inside containers on Circle CI.
When the branch is master and the tests are passing, the job will build an image with the new code, tag it with the commit SHA1 and push it to Dockerhub.
The next step is to create a Openshift Deployment configured with Imagestreams, so every time we push to master it will deploy the code to Openshift.
I have the CircleCI integration working on my fork.
I Could do the integration configuration on the barcelonapm repo but I would need admin rights over the repo.
Salut!