Added data-emoji attribute to generated img tags#26
Open
smeagol74 wants to merge 1 commit intobanyan:masterfrom
Open
Added data-emoji attribute to generated img tags#26smeagol74 wants to merge 1 commit intobanyan:masterfrom
smeagol74 wants to merge 1 commit intobanyan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So img generated for text
:smilie:will looks like<img data-emoji=":smilie:">This is useful when making rich-text-editor that should show emojis as images right in editor, but save the emojis as text. So before saving its content to file or sending as message it is possible to replace all
<img>back to emoji texts usingdata-emojiattributes.