Update gitignore & change mem.alloc to make#1
Open
blob1807 wants to merge 1 commit intobaldgg:masterfrom
Open
Conversation
Add `ols.json` (the lsp's config file) to the `.gitignore`. Change temp atlas & font bit map allocs to a slice & multipointer respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ols.json(the lsp's config file) to the.gitignore.Change mem.alloc to make as it's preferred:
When slicing up the images to add the atlas
copywill copy the min length of dst & src.I'll leave it up to you but
makedoes return an optional error to be handled. It'll crash if unhandled, which it's a bad thing.The allocation changes aren't really needed. It more's to do it how it's preferred to be done in Odin. Or more specifically how
coredoes things.Plus as a tutorial repo make + slices are easier (& safer) than raw dogging pointers.