Skip to content

Pop on unreadable files#28

Merged
konraddysput merged 8 commits intomasterfrom
bugfix/pop-on-unreadable-files
Mar 24, 2026
Merged

Pop on unreadable files#28
konraddysput merged 8 commits intomasterfrom
bugfix/pop-on-unreadable-files

Conversation

@konraddysput
Copy link
Copy Markdown
Contributor

@konraddysput konraddysput commented Mar 24, 2026

If the file doesn't exist, we're popping from the source code collection and this action generates an error, because we're in the middle of iteration.

Error details:

Exception in thread Thread-1 (_worker):
Traceback (most recent call last):
  File "/usr/local/lib/python3.13/threading.py", line 1043, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/usr/local/lib/python3.13/threading.py", line 994, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/backtracepython/report_queue.py", line 32, in _worker
    self.process(report, attachments)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/backtracepython/report_queue.py", line 42, in process
    self.source_code_handler.collect(report)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/backtracepython/source_code_handler.py", line 45, in collect
    for source_code_path in source_code:
                            ^^^^^^^^^^^
RuntimeError: dictionary changed size during iteration

ref: INS-985

@konraddysput konraddysput self-assigned this Mar 24, 2026
@melekr
Copy link
Copy Markdown

melekr commented Mar 24, 2026

only comment i had was around invalid char for python2 which is adressed.

If tests are green, LGTM!

@konraddysput konraddysput merged commit f976359 into master Mar 24, 2026
8 checks passed
@konraddysput konraddysput deleted the bugfix/pop-on-unreadable-files branch March 24, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants