Merged
Conversation
incl fix tests
As the end now can be different from the actual transactions
Already checked in clv.time.set.sample.periods
Consistent order
* add observation.end to missing arrange methods
pschil
changed the title
clvdata(): Parameter observation.endclvdata(): Parameter data.end
* Leave NAs in the data to know how far to plot (also return with NA) * Dont drop NAs anymore but omit during plotting * Tests: Correctness clvdata + plot clv.fitted.transactions * Docu: Returned plot data may now contain NAs
pschil
added a commit
that referenced
this pull request
Oct 29, 2025
As went to CRAN: * Version bump * Bugfix tests: Usage of apparelDynCov data (#287) * Set zval and pval of main model params to NA (#285) * Predict: Rename x.total.spending to x.period.spending (#286) * Dyncov: Rename predicted.CLV -> predicted.period.CLV (#288) * Add hessian(): Calculate hessian for fitted models (#289) * Docu: summary() significance indicators NA (#294) * clv.fitted.get.LL(): Method required for parameter bootstrap (#293) * Vignette: Add authors (#291) * clvdata(): Parameter data.end (#292) * Add vignettes: PDFs as-is (#295) * Rcpp: arma::is_finite() -> std::isfinite() (#296) * Vignettes: Compact during build * Update vignettes and compact before build * Prepare release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concept
data.end> last transaction ANDestimation.split< last transactionestimation.split<data.enddata.endmoves theholdout.endfurther while leaving everything else as-isdata.endmoves theestimation.endfurther (andholdout.start/endwhich fall onestimation.end)Implementation
observation.endtoclvdata()which is passed toclv.time.set.sample.periods()summary.clv.data: Include period start and end into the summary output