feat(Multistate): Shoehorned multistate#373
Draft
mostlynick3 wants to merge 7 commits intoazerothcore:masterfrom
Draft
feat(Multistate): Shoehorned multistate#373mostlynick3 wants to merge 7 commits intoazerothcore:masterfrom
mostlynick3 wants to merge 7 commits intoazerothcore:masterfrom
Conversation
…pstream Eluna Based on parts of azerothcore#249 Co-Authored-By: iThorgrim <125808072+iThorgrim@users.noreply.github.com>
mostlynick3
force-pushed
the
multistate-shoehorn
branch
4 times, most recently
from
1a7c679 to
ac220f2
Compare
mostlynick3
force-pushed
the
multistate-shoehorn
branch
from
ac220f2 to
9c4051a
Compare
Author
|
Now with full instanced map support as well (BGs, raids, dungeons), with each instance running a separate Lua state :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for a shoehorned multistate implementation, aiming to replicate "native" multistate without the need for further core-side support/development. Both compatibility mode and multistate mode are working out of the box but I haven't tested in a prod environment yet and thus cannot safely say it's good to go. I assume more changes will be needed.
Anyone is welcome to test it. I've set compatibility mode enabled by default (or, rather, disabled multistate by default), so that on the off chance that this PR gets merged, mod-ale users' existing scripts will work without requiring rewrites.
Note that Data() methods support is not included in this PR as the original Eluna implementation requires core edits to support it. It's of course possible to serialize and store reload-proof data in mod-ale's cache, and thus get Data() support without core edits, but since it's a bit of a hacky solution I've chosen to omit it.