Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Create mod-tele-new-players.md#34

Open
skxawng-cu wants to merge 4 commits intoazerothcore:masterfrom
skxawng-cu:master
Open

Create mod-tele-new-players.md#34
skxawng-cu wants to merge 4 commits intoazerothcore:masterfrom
skxawng-cu:master

Conversation

@skxawng-cu
Copy link
Copy Markdown

No description provided.

@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 21, 2020

When the module will be tested for at least one tester I will fork the module
(if I find the time I can test it personally)


- Name: TeleNewPlayers
- Author: Skxawng-cu
- Module TeleNewPlayers:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal here?

@BarbzYHOOL
Copy link
Copy Markdown
Member

BarbzYHOOL commented Feb 21, 2020

Thank you for submitting the module.

However I'm wondering, why not use the table playercreateinfo for this purpose @skxawng-cu ? It looks simpler to me

@BarbzYHOOL

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>
@skxawng-cu
Copy link
Copy Markdown
Author

Thank you for submitting the module.

However I'm wondering, why not use the table playercreateinfo for this purpose @skxawng-cu ? It looks simpler to me

That way it is simpler, but I didn't implement it like this for two reasons: 1. I didn't want to affect the server database because that would avoid being able to disable the module at any time; 2. It would be very difficult to modify the coordinates where new players should start.

Co-Authored-By: Barbz <BarbzYHOOL@users.noreply.github.com>
@BarbzYHOOL
Copy link
Copy Markdown
Member

Thank you for submitting the module.
However I'm wondering, why not use the table playercreateinfo for this purpose @skxawng-cu ? It looks simpler to me

That way it is simpler, but I didn't implement it like this for two reasons: 1. I didn't want to affect the server database because that would avoid being able to disable the module at any time; 2. It would be very difficult to modify the coordinates where new players should start.

you can save the sql and run a delete statement and restore original coords
and why would it be difficult to modify?

I'm just saying this in case you haven't tried the other method (because I used the SQL method and I was satisfied with it)

@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 21, 2020

@skxawng-cu if you can, add a file icon.png size max 300x300 in your repo.

@skxawng-cu
Copy link
Copy Markdown
Author

@skxawng-cu if you can, add a file icon.png size max 300x300 in your repo.

Added

@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 21, 2020

@skxawng-cu I am trying to test your module, but at the first build I didn't get the conf into my server/etc/ directory, I am rebuilding a clean AC now

In the meanwhile I suggest you to delete the sql directory (because it contains empty directories, no sql files) and update the README to remove the part about SQL.

@Helias
Copy link
Copy Markdown
Member

Helias commented Feb 21, 2020

I tried the module, but apparently it does not teleport the players to the map.
it only removes the equipped items.

@BarbzYHOOL
Copy link
Copy Markdown
Member

@skxawng-cu I am trying to test your module, but at the first build I didn't get the conf into my server/etc/ directory, I am rebuilding a clean AC now

In the meanwhile I suggest you to delete the sql directory (because it contains empty directories, no sql files) and update the README to remove the part about SQL.

about this, I will improve the create_module script by removing empty directories on git init, i know i have to do it xD

@skxawng-cu
Copy link
Copy Markdown
Author

@BarbzYHOOL, @Helias I already clean the unused sql folder.

@skxawng-cu
Copy link
Copy Markdown
Author

I tried the module, but apparently it does not teleport the players to the map.
it only removes the equipped items.

Check the .conf file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants