fix: correct nosemgrep rule IDs for sagemaker-ai and tools#121
Merged
Conversation
The nosemgrep inline comments used truncated rule IDs that didn't match the full IDs reported by semgrep, so suppressions were silently ignored. All findings are false positives: - format_detector.py: is_valid is a @DataClass bool field, not a method - validate-cross-refs.cjs: marketplacePath is only called with hardcoded string constants, never user input Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
krokoko
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nosemgrepinline comments that used truncated rule IDs, causing suppressions to be silently ignored by semgrepformat_detector.py(3 findings):is_validis a@dataclassboolfield, not a method —-- dataclass field, not a methodvalidate-cross-refs.cjs(4 findings):marketplacePathparameter is only ever called with hardcoded string constants —-- callers pass hardcoded constants, not user inputTest plan
mise run security:semgrep— should show 0 findings (down from 7 in these files)mise run build— passes cleanlyGenerated with Claude Code
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.