I/R: Pass max_connections through PIDE protocol#199
Merged
hanno-becker merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
…n resilient ML_Repl now reports max_connections alongside port and token in the IR_Repl.port protocol message. IQExploreDockable passes it as --pool-size to repl.py, preventing the pool from exceeding the ML connection limit. Pool creation is now best-effort with a 5s connect timeout per connection: failed connections are skipped and logged, only failing if zero succeed. The probe connection is also closed before pool creation to free a slot Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
iq_connection_resilience
branch
from
89bdea1 to
aba7769
Compare
hanno-becker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ML_Repl now reports max_connections alongside port and token in the
IR_Repl.port protocol message. IQExploreDockable passes it as --pool-size
to repl.py, preventing the pool from exceeding the ML connection limit.
Pool creation is now best-effort with a 5s connect timeout per connection:
failed connections are skipped and logged, only failing if zero succeed.
The probe connection is also closed before pool creation to free a slot
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.