Fix namespaced-role-and-bindings helm chart bugs#406
Open
FarhanTejani wants to merge 1 commit intoaws:mainfrom
Open
Fix namespaced-role-and-bindings helm chart bugs#406FarhanTejani wants to merge 1 commit intoaws:mainfrom
FarhanTejani wants to merge 1 commit intoaws:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Fixing two bugs in the
namespaced-role-and-bindingssubchart:Chart.yamldefines the condition asnamespaced-role-and-bindings.enabled, butvalues.yamlusesenable(missing the trailingd). The condition never matches, so the subchart cannot be disabled via values.The RoleBinding template hardcodes
namespace: kubeflowinstead of using{{ .Values.namespace }}. The Role on line 4 is correctly templated, but the RoleBinding on line 37 is not. If a user configures a different namespace, the RoleBinding is created inkubeflowwhile the Role is created in the configured namespace.Before/After UX
Fix 1:
Fix 2:
How was this change tested?
Chart.yamlline 78 usesnamespaced-role-and-bindings.enabledas the conditionvalues.yamluseenabled(this was the only outlier){{ .Values.namespace }}Are unit tests added?
N/A (Helm chart fix)
Are integration tests added?
N/A
Reviewer Guidelines
One of the following must be true: