feat: add active node validation with nodeadm init#779
Open
feat: add active node validation with nodeadm init#779
Conversation
vikash-s1
force-pushed
the
node-active-validation
branch
from
dd8e168 to
754124f
Compare
g-gaston
reviewed
Nov 17, 2025
Comment on lines
+132
to
+134
| runner.Register(validation.New("node-readiness", func(ctx context.Context, informer validation.Informer, obj *api.NodeConfig) error { | ||
| return nodevalidator.ExecuteActiveNodeValidator(ctx, log) | ||
| })) |
Contributor
There was a problem hiding this comment.
are you not using the informer on purpose?
| init.cmd.String(&init.configSource, "c", "config-source", "Source of node configuration. The format is a URI with supported schemes: [file, imds].") | ||
| init.cmd.StringSlice(&init.daemons, "d", "daemon", "Specify one or more of `containerd` and `kubelet`. This is intended for testing and should not be used in a production environment.") | ||
| init.cmd.StringSlice(&init.skipPhases, "s", "skip", fmt.Sprintf("Phases of the bootstrap to skip. Allowed values: [%s].", strings.Join(Phases(), ", "))) | ||
| init.cmd.String(&init.validationTimeout, "v", "validation-timeout", "Validation timeout duration (e.g., 30s, 10m, 1h). This is the timeout for node validation with the Kubernetes cluster after initialization. Set to '0s' to disable validation. Default: 10m") |
Contributor
There was a problem hiding this comment.
can we make the flag name more specific? this sounds like it's for validations but it's not, it's for checking node registration
| defer cancel() | ||
|
|
||
| log.Info("Node initialization finished. Running post-initialization validation to check node status in cluster", zap.Duration("timeout", validationTimeout)) | ||
| if err := nodevalidator.ExecuteActiveNodeValidator(ctx, log); err != nil { |
Contributor
There was a problem hiding this comment.
any reason to run this here instead of the flows.Initer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Add active node validation with nodeadm init command.
Description: Nodeadm init command performs hybrid node initialization process. However, there is no guarantee that the node is successfully registered with the Kubernetes cluster and is in "Ready" state. This change adds the Post-Initialization steps in nodeadm init command and validates if kubernetes client on node is able to fetch the required status from kubernetes api-server.
This validation is enabled by default and users can disable or update the validation wait-timeout duration. Default timeout is 10 minutes.
nodeadm int command update:
-w / --wait-timeout (optional flag) to disable or change the nodeadm init validation timeout
Internally it perform the validation in three steps:
Node Registration Validation - Verifies node is registered with the cluster
CNI Detection - Detects CNI plugin type (Cilium, Calico, or none)
Node Readiness Validation - Ensures node is in Ready state with proper network configuration
Testing (if applicable):
Added unit tests and tested on hybrid node
Successful case
Failed case when CNI supported binary not found
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.