Open
Conversation
OPENSSL_INIT_ATFORK is an OpenSSL 1.1.x flag that registers pthread_atfork() handlers for PRNG fork safety. AWS-LC handles fork detection automatically via kernel-level mechanisms, so this flag is a safe no-op. Define it as 0 alongside the other stubbed OPENSSL_INIT_* flags to unblock consumers that reference it (e.g. Valkey).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 689 689
Lines 122487 122487
Branches 17093 17092 -1
=======================================
+ Hits 95507 95513 +6
+ Misses 26082 26077 -5
+ Partials 898 897 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
OPENSSL_INIT_ATFORK is an OpenSSL 1.1.x flag that registers
pthread_atfork() handlers for PRNG fork safety. AWS-LC handles fork
detection automatically via kernel-level mechanisms, so this flag is a
safe no-op. Define it as 0 alongside the other stubbed OPENSSL_INIT_*
flags to unblock consumers that reference it (e.g. Valkey).
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.