Skip to content

Add a test to validate changing code and env vars#204

Open
willthames wants to merge 2 commits intoaws-controllers-k8s:mainfrom
willthames:add-code-and-config-test
Open

Add a test to validate changing code and env vars#204
willthames wants to merge 2 commits intoaws-controllers-k8s:mainfrom
willthames:add-code-and-config-test

Conversation

@willthames
Copy link

Description of changes:

Create a test that updates both function code and environment variables at the same time.

In theory, both should work, but there is currently a bug that means that only the code gets updated. This test should allow validation of any fix.

Issue #, if available: aws-controllers-k8s/community#1968

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add setup.sh, pickle.sh and teardown.sh scripts to help manage test
infrastructure

Update all configuration to allow flexible regions (no longer
hard-coding to us-west-2)

Update S3 object hash management to store checksum alongside S3
object and use that to validate lambda hashes.
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler February 25, 2026 04:07
@ack-prow
Copy link

ack-prow bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willthames
Once this PR has been reviewed and has the lgtm label, please assign michaelhtm for approval by writing /assign @michaelhtm in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link

ack-prow bot commented Feb 25, 2026

Hi @willthames. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Create a test that updates both function code and environment
variables at the same time.

In theory, both should work, but there is currently a bug that
means that only the code gets updated. This test should allow
validation of any fix.
@willthames willthames force-pushed the add-code-and-config-test branch from 493c1c8 to 04634c5 Compare February 25, 2026 04:30
@willthames
Copy link
Author

This is based on #203 because the test suite doesn't work for me without #203 (for this test, the main problem is non-matching sha256 hashes)

If #203 is rejected then I can unpick the changes but won't be able to validate that the tests succeed locally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant