feat: add TenancyConfig to ACK Lambda Controller#201
feat: add TenancyConfig to ACK Lambda Controller#201acaremrullah wants to merge 23 commits intoaws-controllers-k8s:mainfrom
Conversation
|
Hi @acaremrullah. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @michaelhtm |
knottnt
left a comment
There was a problem hiding this comment.
@acaremrullah Thanks for the PR! Left a few comments.
…te version of sdk to support tenancyconfig
|
/assign @knottnt |
|
Hi @knottnt @michaelhtm any chance to take a look for review this PR :) Thanks in advance |
Co-authored-by: knottnt <trevor.knottnerus@gmail.com>
Co-authored-by: knottnt <trevor.knottnerus@gmail.com>
|
Thank you for commit suggestions @knottnt. I pushed the changes with new generated files. Looking forward for your review. |
|
/assign @knottnt Hey team, any chance to take a look this change if it's good to test? |
|
/ok-to-test |
michaelhtm
left a comment
There was a problem hiding this comment.
Thanks for the contribution @acaremrullah
left a few comments below
|
@acaremrullah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@michaelhtm @knottnt I'm looking forward for your reviews :) |
|
/assign @michaelhtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, acaremrullah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @knottnt |
Issue #, if available: N/A
Description of changes:
Summary
Adds support for AWS Lambda's Tenant Isolation Mode feature to enable per-tenant isolation for multi-tenant applications.
Changes
SDK Update
github.com/aws/aws-sdk-go-v2/service/lambdafromv1.75.0tov1.87.1to include TenancyConfig API supportAPI Types
TenancyConfigtype withTenantIsolationModefield toapis/v1alpha1/types.goTenancyConfigfield toFunctionSpecinapis/v1alpha1/function.goController Implementation
pkg/resource/function/sdk.goto handle TenancyConfig in:newCreateRequestPayload- sets TenancyConfig on CreateFunction API callsdkFind- reads TenancyConfig from GetFunction responsesdkCreate- reads TenancyConfig from CreateFunction responseCRD Updates
config/crd/bases/lambda.services.k8s.aws_functions.yamlandhelm/crds/lambda.services.k8s.aws_functions.yamlTesting
test/e2e/resources/function_tenancy.yamldemonstrating tenant isolation configurationUsage Example
AWS Documentation
Notes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.