Fetch the execution runtime code properly and test the fraud proof verification on parimay node#308
Merged
liuchengxu merged 5 commits intomainfrom Mar 31, 2022
Merged
Conversation
nazar-pc
previously approved these changes
Mar 31, 2022
Member
nazar-pc
left a comment
nazar-pc
left a comment
There was a problem hiding this comment.
Some questions and nits, makes sense otherwise
i1i1
approved these changes
Mar 31, 2022
nazar-pc
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a follow-up of #301. One change worth noticing in this PR is the execution runtime code is now properly fetched from the primary runtime using the runtime API. And then the test for
ProofVerifieris added to test the fraud proof verification on the primary node. There is also a refactoring about the execution proof creation and verification on the executor side. Should be straightforward to review commit by commit.