Implement menu and functionality to discard tabs, fixes #11.#33
Implement menu and functionality to discard tabs, fixes #11.#33sfleiter wants to merge 1 commit intoautonome:masterfrom
Conversation
|
Any feedback on this @autonome? |
autonome
left a comment
autonome
left a comment
There was a problem hiding this comment.
Thanks very much for the PR, and thanks for poking me about it!
I've left a few comments on the PR, mostly minor.
One question is about the use of "retire". I'm not sure it's the right word here. I've been using asleep/awake, so that there's no worry of tabs actually going away. Even those aren't absolutely consistent with "dormant", but I think they're closer?
| // Load (or reload) config from storage | ||
| let oldConfig = config; | ||
| config = await loadConfig(); | ||
| addMenu(); |
There was a problem hiding this comment.
minor nit: add a space between this and the config loading bit, with a comment explaining what's happening
_locales/en/messages.json
Outdated
| "description": "Menu item to retire all selected / highlighted tabs." | ||
| }, | ||
| "menuDiscardLeft": { | ||
| "message": "Retire tabs to the &left", |
There was a problem hiding this comment.
Hm, I'm not familiar enough with localizing entities - what happens with "&left"?
There was a problem hiding this comment.
That l should be underlined and should be an access key.
Have to test this myself on windows as mac does not support this.
There was a problem hiding this comment.
Yes, it works on Windows in my VM.
I did on purpose create one for the menu group since that could collide with future Firefox tab menu entries.
See here (access keys are underlined):
I thought a bit more about it and would like to use "put so sleep" throughout according to https://www.merriam-webster.com/dictionary/put%20to%20sleep bullet 3. Maybe it is time for more consistency and use Dormany only as the extension name and otherwise stay with (put to) sleep and awake or wake up? |
|
New version of the code pushed |
sfleiter
force-pushed
the
add-menu
branch
2 times, most recently
from
f42645c to
1bc7794
Compare
2 participants
Merry Christmas!
This pull request adds a tab menu for Dormancy to discard selected, left, right or other tabs.
If anything comes up during review please do not hesitate to tell me about it.