UPSTREAM PR #2448: Use GIX_TEST_FIXTURE_HASH for gix-refspec#25
UPSTREAM PR #2448: Use GIX_TEST_FIXTURE_HASH for gix-refspec#25
GIX_TEST_FIXTURE_HASH for gix-refspec#25Conversation
OverviewAnalysis of 26,403 functions across two Gitoxide binaries reveals negligible performance impact between versions. Modified functions: 32 (0.12%), new: 124, removed: 124, unchanged: 26,123 (98.94%). Power consumption increased 0.004% for both Function AnalysisThe 🔎 Full breakdown: Loci Inspector |
|
No summary available at this time. Visit Loci Inspector to review detailed analysis. |
3a9c4ae to
a28c634
Compare
3deba97 to
9b41e5f
Compare
5c1e949 to
37bef49
Compare
|
No meaningful performance changes were detected across 26512 analyzed functions in the following binaries: target.aarch64-unknown-linux-gnu.release.gix, target.aarch64-unknown-linux-gnu.release.ein. 🔎 Full breakdown: Loci Inspector |
a9e7940 to
d9d8ccd
Compare
Note
Source pull request: GitoxideLabs/gitoxide#2448
This PR adds
sha256support togix-refspectests. It adds thesha256feature flag todev-dependenciesand runs the test suite forgix-refspecfor bothsha1andsha256. It adds separate branches for SHA-256 in a few places where SHA-1 hashes were hardcoded.Open questions
gix-refspec/tests/fixtures/generated-archives/.gitignoreincludes/match_baseline.tar. Does it also need to include/match_baseline_sha256.tar? (I haven’t committed the latter yet.)gix_refspec::parse::function::looks_like_object_hashusesgix_hash::Kind::shortest. Does it need to be changed? (I suspect it doesn’t.)