fix(html-template-element): fix template.content.cloneNode#25
fix(html-template-element): fix template.content.cloneNode#25StrahilKazlachev wants to merge 1 commit intoaurelia:masterfrom
Conversation
|
@jdanyow Are you able to review this? |
|
@StrahilKazlachev sorry for the delay- this is looking good, I agree with you, no need to use the lazy pattern here. Would you be willing to refactor the lazy stuff out and add a test? If you npm install |
|
@jdanyow Will refactor and ping you when ready. |
where native support is missing fix aurelia/templating#569
964fde7 to
fd5331f
Compare
|
@jdanyow So it took me a lot more time to come back to this 😭 |
|
@jdanyow What do you think? Good to merge? |
|
Ping @jdanyow for review. |
|
@jdanyow Could you take another look at this? |
|
@StrahilKazlachev Do you feel pretty good about this? |
where native support is missing fix aurelia/templating#569
@jdanyow could you review?
I'm not sure how good idea is to reassign
.cloneNodefor a second time inlazySafeCloneNode.