vswitch: Add vswitch component by JDuchniewicz · Pull Request #685 · au-ts/sddf

JDuchniewicz · 2026-03-30T02:17:09Z

Adds a vswitch component following #636

Allows for connecting up to 62 clients and one TX/RX Virt pair with the vswitch. Tested with PR: au-ts/libvmm#207 and depends on microkit_sdf_gen PR: au-ts/microkit_sdf_gen#31

The support for connecting vswitches back to back might be added later.

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

midnightveil · 2026-03-30T02:31:10Z

You appear to have broken all the echo server examples per CI.

It would be good to add an example/CI test for this. Same applies to libVMM itself.

(My other question: is vswitch a driver or an (Lions)OS component...?)

JDuchniewicz · 2026-03-30T02:41:15Z

You appear to have broken all the echo server examples per CI.

It would be good to add an example/CI test for this. Same applies to libVMM itself.

Yes, I will add the necessary test, example is in libVMM. Should we also have one here?

(My other question: is vswitch a driver or an (Lions)OS component...?)

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

midnightveil · 2026-03-30T03:04:06Z

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

What I mean is "does it make more sense as part of LionsOS than sDDF"?

JDuchniewicz · 2026-03-30T03:12:00Z

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

What I mean is "does it make more sense as part of LionsOS than sDDF"?

I don't know where we draw the line between, this is "driver/should be in sDDF" and "this is too high-level for sDDF". I presume current components are crucial enough to be here. This is somewhere in-between as it is an optional system component.

include/sddf/network/mac802.h

Kswin01 · 2026-03-30T03:02:30Z

drivers/network/imx/ethernet.c

    eth->racc = RACC_LINEDIS | RACC_IPDIS | RACC_PRODIS;
    /* Add the checksum for known IP protocols */
-    eth->tacc = TACC_PROCHK | TACC_IPCHK;
+    //eth->tacc = TACC_PROCHK | TACC_IPCHK; // TODO: disabled because VM does that as well


Is enabling hardware checksumming something that can be put into the net driver config?

Yes, I can extend that. We should probably align that with how it is done for LWIP - currently as #ifdef:

sddf/include/sddf/network/constants.h

Line 34 in 8792b60

#if defined(CONFIG_PLAT_IMX8MM_EVK) || defined(CONFIG_PLAT_MAAXBOARD) || defined(CONFIG_PLAT_IMX8MP_EVK) \

This is more to define if the hardware has support for it, but we should also be able to optionally turn on/off certain hardware features

@Ivan-Velickovic what are your thoughts - I can add this as part of this PR, or alternatively create a new PR with the option to set/unset that option. Also, what other options would we want to be able to configure dynamically?

Kswin01 · 2026-03-30T03:06:03Z

include/sddf/network/mac802.h

+
+/* This is a name for the 96 bit ethernet addresses available on many
+   systems.  */
+struct ether_addr {


This is a bit of a duplication of what's already in constants.h. Would it be possible to just extend that rather than redefining here?

We can, IMO it's not a bad idea to split headers according to what they provide/represent instead of having one big constants.h but I am open to a discussion.

Yeh I'm not opposed to that either, I believe the firewall includes in LionsOS already separate things out such as ethernet, icmp, tcp, and udp constants: https://github.com/au-ts/lionsos/blob/main/include/lions/firewall/ethernet.h.

Maybe it's worth bringing some of those into sDDF and extending them?

We would need just what I included here right now. I don't think adding most of them makes sense unless we will use them.

Yeh probably only ethernet is relevant for sDDF

Commonalized somewhat - please take a look

include/sddf/network/queue.h

network/components/virt_tx.c

Kswin01 · 2026-03-30T03:15:39Z

network/components/vswitch.c

+
+#define VSWITCH_VIRT_PORT (SDDF_NET_MAX_CLIENTS - 1)
+
+#define NUM_BUFFERS (512)


Could this be passed in through the vswitch config?

this is actually an omission on my side - I have been thinking how to properly define this. This comes from:

sddf/include/sddf/network/config.h

Line 55 in 8792b60

// 4*drv_queue_capacity. It must be mapped R-W and zero-initialised.

As we initialize the drv_queue_capacity with the number of rx_buffers in SDFgen: https://github.com/au-ts/microkit_sdf_gen/blob/main/src/sddf/net.zig#L251

This was supposed to be temporary - I think this needs to be passed into the elf section through SDFgen.

Kswin01 · 2026-03-30T03:18:21Z

include/sddf/network/config.h

    net_connection_resource_t conn;
-    device_region_resource_t data;
+    device_region_resource_t data[SDDF_NET_MAX_CLIENTS];
+    uint8_t num_data;


Is uint8 enough here? Most systems have more than 255 buffers

maybe the name is confusing - we can have up to 63 Clients, therefore num_data will be also up to 63.

Corrected, please take a look.

Kswin01 · 2026-03-30T03:19:26Z

I'll have a proper read through the vswitch implementation later, but a few nitpicks of the surrounding updates

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

JDuchniewicz · 2026-03-31T00:42:58Z

@Courtney3141 I think it's prudent to first merge this, then create a new PR for the new example with 2 echo_server's as there might be a substantial amount of new files. Also, libvmm depends on it and not necessarily on the presence of the sddf example.

Courtney3141 · 2026-03-31T01:16:41Z

@Courtney3141 I think it's prudent to first merge this, then create a new PR for the new example with 2 echo_server's as there might be a substantial amount of new files. Also, libvmm depends on it and not necessarily on the presence of the sddf example.

Agreed.

JDuchniewicz added 14 commits February 9, 2026 16:47

network: port vswitch from alexandermbrown

f2e61f5

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: adapt to new microkit

92847d0

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: Design the config structure

2902cd9

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: flesh out sending

5707f22

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: first implementation

2fddcc9

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: fixup rx and tx, minor vswitch fixes

20cbf5f

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: fixups for compilation

4cdf9fb

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: Makefile fixes

1ef6978

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: debugging and small fixes

4efeb94

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: add copiers having mappings to other pds

ac544bd

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: Fix wrong default port. virt buf.oid stamping

6d39782

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

ubsan: fix wrong cast

4b71940

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: add logs to eth driver

6d988c2

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: cleanup logs

010f68d

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

JDuchniewicz requested review from Courtney3141, Ivan-Velickovic and Kswin01 March 30, 2026 02:17

JDuchniewicz force-pushed the jakub/vswitch branch from 17cd4e0 to 861c81b Compare March 30, 2026 02:18

vswitch: cleanup

861c81b

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

This was referenced Mar 30, 2026

vswitch: Add support for vswitch component au-ts/microkit_sdf_gen#31

Open

vswitch: Add a vswitch example with small fixups au-ts/libvmm#207

Open

JDuchniewicz force-pushed the jakub/vswitch branch from 8f1168b to 61938c0 Compare March 30, 2026 02:55

style: lint

61938c0

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

Kswin01 reviewed Mar 30, 2026

View reviewed changes

address review comments

845cbf8

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>

vswitch: fix up naming

3922d64

Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>


		#define VSWITCH_VIRT_PORT (SDDF_NET_MAX_CLIENTS - 1)

		#define NUM_BUFFERS (512)

Conversation

JDuchniewicz commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

midnightveil commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JDuchniewicz commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

midnightveil commented Mar 30, 2026

Uh oh!

JDuchniewicz commented Mar 30, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kswin01 Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kswin01 commented Mar 30, 2026

Uh oh!

JDuchniewicz commented Mar 31, 2026

Uh oh!

Courtney3141 commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JDuchniewicz commented Mar 30, 2026 •

edited

Loading

midnightveil commented Mar 30, 2026 •

edited

Loading

JDuchniewicz commented Mar 30, 2026 •

edited

Loading

Kswin01 Mar 30, 2026 •

edited

Loading