Open
Conversation
MSVC (at least) complains about trying to store data from a larger type (such as size_t) in a smaller type (such as uint16_t) unless you expicitly cast the value.
3 tasks
Collaborator
|
Looks good. I will review the consistency of uint16_t and size_t types before the next release. |
silentbicycle
added a commit
that referenced
this pull request
Jul 4, 2021
They mostly had to do with mixing up numeric types. Make a couple code style changes to clarify behavior, especially regarding return types. Closes #38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC (at least) complains about trying to store data from a larger type
(such as size_t) in a smaller type (such as uint16_t) unless you
expicitly cast the value.