Preserve read metadata bytes on rewrite#142
Open
InternetRando1 wants to merge 1 commit intoatenfyr:masterfrom
Open
Preserve read metadata bytes on rewrite#142InternetRando1 wants to merge 1 commit intoatenfyr:masterfrom
InternetRando1 wants to merge 1 commit intoatenfyr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes loss of MetaData section when roundtripping UE5.4+ assets
Steps to reproduce:
Root cause:
UAsset.ReadHeader() reads MetaDataOffset (introduced in UE5.4), but the corresponding
bytes are never read or preserved. During write:
This causes:
Observed impact:
For a UE5.7 Material asset, this removes 53 bytes of build dependency hash data.
The resulting file is rejected by Unreal Editor.
What the MetaData section contains:
Raw bytes between MetaDataOffset and ImportOffset.
In UE5.7 this includes package build dependency metadata (hash strings).
This format is currently not parsed by UAssetAPI.
Fix:
Preserve the MetaData section as raw bytes (passthrough):
This preserves correctness without introducing format-specific parsing.
Future work could deserialize this section if needed.