Add mouse text selection to plan-review widget#108
Open
astex wants to merge 1 commit intoplan-review-pr4-rich-markdownfrom
Open
Add mouse text selection to plan-review widget#108astex wants to merge 1 commit intoplan-review-pr4-rich-markdownfrom
astex wants to merge 1 commit intoplan-review-pr4-rich-markdownfrom
Conversation
Tracks selection in widget Tree state with anchor/head points in markdown-line coordinates, mirroring the alacritty selection lifecycle. Pixel positions are mapped to (line, char) via per-line layouts that share the y-advancement logic with draw. Selection is highlighted with a translucent foreground rect per affected line. Exposes a selected_text helper for PR-6 to consume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks selection in widget Tree state with anchor/head points in markdown-line coordinates, mirroring the alacritty selection lifecycle. Pixel positions map to (line, char) via per-line layouts that share y-advancement logic with draw, and selection is highlighted with a translucent foreground rect per affected line. Exposes a selected_text helper for PR-6 to consume.