Fix PostgreSQL index creation for whatsmeow_message_secrets#280
Fix PostgreSQL index creation for whatsmeow_message_secrets#280asternic merged 2 commits intoasternic:mainfrom
Conversation
…nd maintainability
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in PostgreSQL environments where the schema initialization process could fail due to an incompatible index creation statement. By modifying the SQL migration for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reorders the database schema initialization logic in main.go, moving it to a later stage in the application startup. Additionally, the migrations.go file updates a PostgreSQL index creation statement to wrap it within a DO $$ BEGIN ... END $$; block, likely for improved idempotency. A review comment points out a redundant error check in main.go following the initializeSchema call, suggesting it can be safely removed.
…to ensure compatibility with PostgreSQL
de21831 to
3025558
Compare
Summary
This change updates the migration responsible for creating the
whatsmeow_message_secrets_message_id_idxindex on thewhatsmeow_message_secretstable.The migration now uses a PostgreSQL-compatible
DO $$ ... $$block withCREATE INDEX IF NOT EXISTS, avoiding compatibility issues caused by the previousCREATE INDEX CONCURRENTLY IF NOT EXISTSstatement during schema initialization.Also change the initializeSchema to run after WhatsMeow store is initilized, because the migration depends on whatsmeow_message_secrets table
Why
The previous migration could fail or behave inconsistently in PostgreSQL environments, especially when executed as part of the application migration flow. This update makes index creation safer and more reliable during startup.
Impact
message_idindex is created more reliably