Skip to content

Fix PostgreSQL index creation for whatsmeow_message_secrets#280

Merged
asternic merged 2 commits intoasternic:mainfrom
black-atom:fix/add-index-migration
Mar 25, 2026
Merged

Fix PostgreSQL index creation for whatsmeow_message_secrets#280
asternic merged 2 commits intoasternic:mainfrom
black-atom:fix/add-index-migration

Conversation

@vitorsilvalima
Copy link
Copy Markdown
Contributor

Summary

This change updates the migration responsible for creating the whatsmeow_message_secrets_message_id_idx index on the whatsmeow_message_secrets table.
The migration now uses a PostgreSQL-compatible DO $$ ... $$ block with CREATE INDEX IF NOT EXISTS, avoiding compatibility issues caused by the previous CREATE INDEX CONCURRENTLY IF NOT EXISTS statement during schema initialization.

Also change the initializeSchema to run after WhatsMeow store is initilized, because the migration depends on whatsmeow_message_secrets table

Why

The previous migration could fail or behave inconsistently in PostgreSQL environments, especially when executed as part of the application migration flow. This update makes index creation safer and more reliable during startup.

Impact

  • Fixes PostgreSQL migration compatibility
  • Ensures the message_id index is created more reliably
  • Keeps SQLite handling unchanged

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in PostgreSQL environments where the schema initialization process could fail due to an incompatible index creation statement. By modifying the SQL migration for the whatsmeow_message_secrets_message_id_idx index and adjusting the order of schema initialization, the changes ensure more robust and reliable application startup, particularly for PostgreSQL users. This enhances the stability of the application's database setup without impacting SQLite handling.

Highlights

  • PostgreSQL Index Creation Fix: Updated the addWhatsmeowMessageSecretsMessageIDIndexSQL migration to use a PostgreSQL-compatible DO $$ ... $$ block with CREATE INDEX IF NOT EXISTS, resolving compatibility issues that arose from the previous CREATE INDEX CONCURRENTLY IF NOT EXISTS during schema initialization.
  • Schema Initialization Order: Reordered the initializeSchema call in main.go to execute after the WhatsMeow store is initialized, ensuring that the necessary whatsmeow_message_secrets table exists before the migration attempts to create an index on it.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorders the database schema initialization logic in main.go, moving it to a later stage in the application startup. Additionally, the migrations.go file updates a PostgreSQL index creation statement to wrap it within a DO $$ BEGIN ... END $$; block, likely for improved idempotency. A review comment points out a redundant error check in main.go following the initializeSchema call, suggesting it can be safely removed.

@vitorsilvalima vitorsilvalima force-pushed the fix/add-index-migration branch from de21831 to 3025558 Compare March 25, 2026 13:47
@asternic asternic merged commit f80dd1e into asternic:main Mar 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants