This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Use Spans to report better error locations#612
Closed
Kijewski wants to merge 9 commits intoaskama-rs:mainfrom
Kijewski:pr-compile-errors-with-spans
Closed
Use Spans to report better error locations#612Kijewski wants to merge 9 commits intoaskama-rs:mainfrom Kijewski:pr-compile-errors-with-spans
Kijewski wants to merge 9 commits intoaskama-rs:mainfrom
Kijewski:pr-compile-errors-with-spans
Conversation
vallentin
reviewed
Jan 24, 2022
djc
reviewed
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR might look huge and incomprehensible, but it actually shouldn't be too difficult to read. I hope.
Currently if the parsing fails, an error in
#[derive(Template)]is reported, even though the library knows a more narrow location, e.g. at least that the error is actually in#[template(…)], or in thepath = "…"argument if the file is absent.This PR is also done in anticipation of rust-lang/rfcs#3200, which might make it possible to report an error location in the actual template file; and #600, which adds multiple files as possible template file source of an error.