fix metric server shutdown using already-canceled context#712
Merged
gertd merged 1 commit intoaserto-dev:mainfrom Mar 31, 2026
Merged
fix metric server shutdown using already-canceled context#712gertd merged 1 commit intoaserto-dev:mainfrom
gertd merged 1 commit intoaserto-dev:mainfrom
Conversation
StopServers is called via defer after topazApp.Context is canceled, so deriving the shutdown timeout from that context causes immediate cancellation. Use context.Background() instead, and remove the now unused context parameter. Made-with: Cursor
Member
|
Thanks @ashwinrs for the PR. This was outstanding, and hence the reason why We discussed this morning and believe the current proposed fix is too narrow; we would want the complete We will refactor on top of your PR to achieve this. Thanks again for the support & help! |
gertd
approved these changes
Mar 31, 2026
Member
|
After more debate, that is what you already managed to do, so we took the change as-is, our confusion, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StopServersis called viadeferaftertopazApp.Contextis already canceled, so deriving the shutdown timeout context from it causeshttp.Server.Shutdownto fail immediately with"context canceled".context.Background()as the parent for the shutdown timeout context so the metric server (and gateway servers) get the full graceful shutdown window.context.Contextparameter fromStopServers.Test plan
topazd runshuts down cleanly without the"failed to shutdown metric server"error.Made with Cursor