Open
Conversation
Merge Genevieve's PR into new branch.
- Precompute 2*pi, pi/2, wl**2, wl**3, 2*angast - assert kV is available (and therefore wl) - Cs in A for Z(0,4)
- Also some additional corrections
Contributor
Author
|
I've been given some example data I've been told I can share here. You can download the files from here. They include:
I generated the pyem .star file like this: |
Contributor
Author
|
I've also been taking a look at the output of the first particle. It says that particle was from optics group 2, so I'm comparing those values to the ones from the optics group table in line 2. I'm not expecting to see the values match exactly, but in some cases I see values that differ by several orders of magnitude which does indicate a problem. _rlnBeamTiltX
_rlnBeamTiltY
_rlnOddZernike
_rlnEvenZernike
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing work from #87
I've done some testing with files from our lab, and it looks like there are some changes needed to make the output here march an equivalent output created in Relion.
Summarizing what I've found:
This PR was created from a straight copy of @asarnow's
convert_zernikebranch, which builds on top of #87. I haven't made any changes to my copy of branch just yet. I've opened the pull request like this so that both of us could make changes to the same branch (because I can't push to Daniel'sconvert_zernikebranch but he can push to this one).