Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts logging severity/verbosity across several subsystems and expands handling of “default” sentinel strings in configuration values (supporting both DEFAULT and Default) to reduce noisy warnings and improve compatibility with mixed-case defaults.
Changes:
- Introduces
TableViewColumnInfo::DATATYPE_STRING_ALT_DEFAULT("Default") and updates multiple default checks to treat both"DEFAULT"and"Default"equivalently. - Downgrades/retunes several log statements from
WARN/DEBUGtoTRACE(and adjusts debug verbosity in a few hot paths). - Refines Remote Gateway behavior: validates URL format before UDP send, improves broadcast timeout messaging, and conditionally remaps
Abort -> Stopfor “DoNotHalt” remote gateways.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| otsdaq/WebUsersUtilities/WebUsers.cc | Retunes system-message debug output to trace-level verbosity. |
| otsdaq/TablePlugins/DesktopIconTableImpl.cc | Uses getValueWithDefault for permissions/folderPath to avoid manual "DEFAULT" handling. |
| otsdaq/TablePlugins/ARTDAQTableBase/ARTDAQTableBase.cc | Treats "Default" like "DEFAULT" when interpreting subsystem destinations/names. |
| otsdaq/TableCore/TableViewColumnInfo.h | Adds DATATYPE_STRING_ALT_DEFAULT declaration. |
| otsdaq/TableCore/TableViewColumnInfo.cc | Defines "Default" alt-default and updates bitmap “map-to-strings” default handling. |
| otsdaq/TableCore/TableView.cc | Retunes log severity (notably in getColStatus) and reduces group-membership debug verbosity. |
| otsdaq/GatewaySupervisor/GatewaySupervisor.cc | Improves FSM/status edge handling, remote gateway URL validation, broadcast timeout messaging, and per-remote command adjustments. |
| otsdaq/FiniteStateMachine/RunControlStateMachine.cc | Reuses FiniteStateMachine constants for Initial/Configure names. |
| otsdaq/FiniteStateMachine/FiniteStateMachine.h | Adds INITIAL_STATE_NAME and CONFIGURE_TRANSITION_NAME constants. |
| otsdaq/FiniteStateMachine/FiniteStateMachine.cc | Reduces severity for a known “Configure from Initial” missing-transition-name case. |
| otsdaq/FECore/FEVInterfacesManager.cc | Removes duplicate configure logging and accepts "Default" in multidim FE macro parsing. |
| otsdaq/FECore/FEVInterface.h | Adds FEVInterface::DEFAULT sentinel for FE macro default args. |
| otsdaq/FECore/FEVInterface.cc | Defines FEVInterface::DEFAULT (currently mapped to "Default"). |
| otsdaq/CoreSupervisors/FESupervisor.cc | Uses getValueWithDefault for metric preamble (removes manual "DEFAULT" conversion). |
| otsdaq/CoreSupervisors/ConfigurationSupervisorBase.cc | Treats "Default" like "DEFAULT" for icon linked-app handling. |
| otsdaq/ConfigurationInterface/ConfigurationTree.icc | Treats "Default" like "DEFAULT" when decoding bitmap default values. |
| otsdaq/ConfigurationInterface/ConfigurationTree.cc | Treats "Default" like "DEFAULT" in bitmap/default detection logic. |
| otsdaq/ConfigurationInterface/ConfigurationManager.cc | Retunes verbosity during FHICL recursive init and gates view->print() behind a debug test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eflumerf
approved these changes
Mar 19, 2026
Contributor
eflumerf
left a comment
eflumerf
left a comment
There was a problem hiding this comment.
This doesn't do anything to help my hatred of CoutMacros...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.