Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: we run
Koala.reset_configin abefore(:each)to avoid mutation on the globalKoala.configurationobject.But there are some specs (for example ./spec/cases/test_users_spec.rb:285) which have their own
before(:each)making calls to the graph api (before the reset) and in some cases it conflicts with the current state of theKoala.configurationfor example after a test setting a bad configuration on purposeProposed fix is to reset the configuration in an
after(:each)instead