Open
Conversation
Author
|
Ah, I see some of the batch tests don't expect a response and thus don't mock it which is causing an infinite loop in the test. I'll fix that. |
dmitchell
force-pushed
the
dhm/truncated
branch
from
ab22889 to
18c67f5
Compare
|
Seems OK, but shouldn't Faceplant return a 207 on these? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes FB is responding with fewer than the submitted batch. I have been logging it for a while, and it seems to be a simple truncation. I've asked FB for confirmation and clarification. (My code often submits O(10^5) commands at a time.) I believe the truncation has to do w create commands.
I'm not sure how, for LIVE test, to disable the
before :each allow.. and return()logic so that it really submits the request to FB.Thanks for submitting a pull request to Koala! A huge portion of the gem has been built by awesome people (like you) from the Ruby community.
Here are a few things that will help get your pull request merged in quickly. None of this is required -- you can delete anything not relevant. If in doubt, open the PR! I want to help.
[x] My PR has tests and they pass!
[x] The live tests pass for my changes (
LIVE=true rspec-- unrelated failures are okay).[x] The PR is based on the most recent master commit and has no merge conflicts.
If you have any questions, feel free to open an issue or comment on your PR!
Note: Koala has a code of conduct. Check it out.