Skip to content

refactor: the logic "transformMethod parse" #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
coryhh wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: the logic "transformMethod parse" #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 21 additions & 27 deletions arex-web-core/src/main/java/com/arextest/web/core/business/SystemConfigurationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
package com.arextest.web.core.business;

import com.arextest.common.model.classloader.RemoteJarClassLoader;
import com.arextest.common.utils.RemoteJarLoaderUtils;
import com.arextest.config.model.dao.config.SystemConfigurationCollection;
import com.arextest.config.model.dto.system.ComparePluginInfo;
import com.arextest.config.model.dto.system.SystemConfiguration;
import com.arextest.config.repository.SystemConfigurationRepository;
import com.arextest.diff.service.DecompressService;
import com.arextest.web.core.business.config.replay.ComparisonTransformConfigurableHandler;
import com.arextest.web.model.contract.contracts.config.SystemConfigWithProperties;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.Objects;
import javax.annotation.Resource;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.collections4.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
import org.springframework.beans.BeanUtils;
import org.springframework.stereotype.Service;
Expand All @@ -33,6 +29,8 @@ public class SystemConfigurationService {

@Resource
private ConfigLoadService configLoadService;
@Resource
private ComparisonTransformConfigurableHandler comparisonTransformConfigurableHandler;

public boolean saveConfig(SystemConfiguration systemConfiguration) {
List<SystemConfiguration> systemConfigurations = new ArrayList<>();
Expand All @@ -55,10 +53,10 @@ public boolean saveConfig(SystemConfiguration systemConfiguration) {
removeKeys.add(SystemConfigurationCollection.KeySummary.DESERIALIZATION_JAR);
}
if (systemConfiguration.getComparePluginInfo() != null
&& StringUtils.isNotBlank(systemConfiguration.getComparePluginInfo().getComparePluginUrl())) {
&& StringUtils.isNotBlank(
systemConfiguration.getComparePluginInfo().getComparePluginUrl())) {
SystemConfiguration comparePluginInfoConfig = new SystemConfiguration();
ComparePluginInfo comparePluginInfo = systemConfiguration.getComparePluginInfo();
comparePluginInfo.setTransMethodList(identifyTransformMethod(comparePluginInfo));
comparePluginInfoConfig.setComparePluginInfo(comparePluginInfo);
comparePluginInfoConfig.setKey(SystemConfigurationCollection.KeySummary.COMPARE_PLUGIN_INFO);
systemConfigurations.add(comparePluginInfoConfig);
Expand Down Expand Up @@ -92,6 +90,7 @@ public SystemConfiguration getSystemConfigByKey(String key) {

public SystemConfigWithProperties listSystemConfig() {
List<SystemConfiguration> systemConfigurations = systemConfigurationRepository.getAllSystemConfigList();
appendTransformMethod(systemConfigurations);
SystemConfiguration systemConfiguration = SystemConfiguration.mergeConfigs(
systemConfigurations);
return this.appendGlobalCompareConfig(
Expand All @@ -103,28 +102,23 @@ public boolean deleteSystemConfigByKey(String key) {
return systemConfigurationRepository.deleteConfig(key);
}

private List<String> identifyTransformMethod(ComparePluginInfo comparePluginInfo) {
String comparePluginUrl = comparePluginInfo.getComparePluginUrl();
if (StringUtils.isEmpty(comparePluginUrl)) {
return Collections.emptyList();
}

Set<String> result = new HashSet<>();
try {
RemoteJarClassLoader remoteJarClassLoader = RemoteJarLoaderUtils.loadJar(comparePluginUrl);
List<DecompressService> decompressServices = RemoteJarLoaderUtils.loadService(
DecompressService.class, remoteJarClassLoader);
decompressServices.forEach(
decompressService -> {
if (decompressService.getAliasName() != null) {
result.add(decompressService.getAliasName());
private void appendTransformMethod(List<SystemConfiguration> systemConfigurations) {
if (CollectionUtils.isNotEmpty(systemConfigurations)) {
systemConfigurations.stream()
.filter(item -> Objects.equals(item.getKey(),
SystemConfigurationCollection.KeySummary.COMPARE_PLUGIN_INFO))
.forEach(item -> {
if (item.getComparePluginInfo() == null ||
StringUtils.isEmpty(item.getComparePluginInfo().getComparePluginUrl())) {
return;
}
List<String> transformMethodList = comparisonTransformConfigurableHandler.getTransformMethodList(
item);
ComparePluginInfo comparePluginInfo = item.getComparePluginInfo();
comparePluginInfo.setTransMethodList(transformMethodList);
});
remoteJarClassLoader.close();
} catch (RuntimeException | IOException e) {
LOGGER.error("identifyTransformMethod failed, url:{}, exception:{}", comparePluginUrl, e);
}
return new ArrayList<>(result);
}

private SystemConfigWithProperties appendGlobalCompareConfig(ConfigLoadService configLoadService,
Expand Down
67 changes: 64 additions & 3 deletions .../com/arextest/web/core/business/config/replay/ComparisonTransformConfigurableHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,39 @@
package com.arextest.web.core.business.config.replay;

import com.arextest.common.model.classloader.RemoteJarClassLoader;
import com.arextest.common.utils.RemoteJarLoaderUtils;
import com.arextest.config.model.dao.config.SystemConfigurationCollection.KeySummary;
import com.arextest.config.model.dto.application.ApplicationOperationConfiguration;
import com.arextest.config.model.dto.system.ComparePluginInfo;
import com.arextest.config.model.dto.system.SystemConfiguration;
import com.arextest.config.repository.ConfigRepositoryProvider;
import com.arextest.diff.service.DecompressService;
import com.arextest.web.common.LogUtils;
import com.arextest.web.core.business.SystemConfigurationService;
import com.arextest.web.core.business.config.application.ApplicationOperationConfigurableHandler;
import com.arextest.web.core.repository.AppContractRepository;
import com.arextest.web.core.repository.FSInterfaceRepository;
import com.arextest.web.core.repository.mongo.ComparisonTransformConfigurationRepositoryImpl;
import com.arextest.web.model.contract.contracts.config.replay.ComparisonTransformConfiguration;
import com.arextest.web.model.dto.filesystem.FSInterfaceDto;
import com.google.common.collect.ImmutableMap;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import javax.annotation.Resource;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.StringUtils;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Lazy;
import org.springframework.stereotype.Component;

/**
* Created by rchen9 on 2022/9/16.
*/
@Slf4j
@Component
public class ComparisonTransformConfigurableHandler
extends AbstractComparisonConfigurableHandler<ComparisonTransformConfiguration> {
Expand All @@ -32,6 +45,7 @@ public class ComparisonTransformConfigurableHandler
@Resource
ComparisonTransformConfigurationRepositoryImpl comparisonTransformConfigurationRepository;

@Lazy
@Resource
SystemConfigurationService systemConfigurationService;

Expand Down Expand Up @@ -73,9 +87,56 @@ public List<ComparisonTransformConfiguration> queryByInterfaceId(String interfac
public List<String> getTransformMethodList() {
SystemConfiguration comparePluginInfoConfig = systemConfigurationService.getSystemConfigByKey(
KeySummary.COMPARE_PLUGIN_INFO);
return getTransformMethodList(comparePluginInfoConfig);
}

public List<String> getTransformMethodList(SystemConfiguration comparePluginSystemConfig) {
if (comparePluginSystemConfig == null
|| comparePluginSystemConfig.getComparePluginInfo() == null) {
return Collections.emptyList();
}

ComparePluginInfo comparePluginInfo = comparePluginSystemConfig.getComparePluginInfo();
String comparePluginUrl = comparePluginInfo.getComparePluginUrl();
List<String> transMethodList = comparePluginInfo.getTransMethodList();

return comparePluginInfoConfig ==null || comparePluginInfoConfig.getComparePluginInfo() == null
? Collections.emptyList()
: comparePluginInfoConfig.getComparePluginInfo().getTransMethodList();
if (StringUtils.isNotEmpty(comparePluginUrl) && transMethodList != null) {
return transMethodList;
}

// update transformMethod in SystemConfiguration
List<String> transformMethod = identifyTransformMethod(comparePluginInfo);
comparePluginInfo.setTransMethodList(transformMethod);
systemConfigurationService.saveConfig(comparePluginSystemConfig);
return transformMethod;
}

private List<String> identifyTransformMethod(ComparePluginInfo comparePluginInfo) {
String comparePluginUrl = comparePluginInfo.getComparePluginUrl();
if (StringUtils.isEmpty(comparePluginUrl)) {
return Collections.emptyList();
}

LogUtils.info(LOGGER, ImmutableMap.of("title", "identifyTransformMethod"),
"identifyTransformMethod, url:{}", comparePluginUrl);
Set<String> result = new HashSet<>();
try {
RemoteJarClassLoader remoteJarClassLoader = RemoteJarLoaderUtils.loadJar(comparePluginUrl);
List<DecompressService> decompressServices = RemoteJarLoaderUtils.loadService(
DecompressService.class, remoteJarClassLoader);
decompressServices.forEach(
decompressService -> {
if (decompressService.getAliasName() != null) {
result.add(decompressService.getAliasName());
}
});
remoteJarClassLoader.close();
} catch (RuntimeException | IOException e) {
LogUtils.error(LOGGER, ImmutableMap.of("title", "identifyTransformMethod"),
"identifyTransformMethod failed, url:{}, exception:{}", comparePluginUrl, e);
}
return new ArrayList<>(result);
}


}