Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed issue with initial generation of equilibrium cycle cores. When generating a gene for a chromosome, MIDAS creates a list of the possible genes to use in that position (based on input constraints). It is possible for this list to be empty, but random.choice() is used to select the gene and this will return an error if the list is empty. MIDAS really should not return an error in the situation where the list is empty and should instead retry to create the chromosome from scratch. This was fixed in the patch.
A similar issue was happening with the initial generation of single cycle chromosomes which was fixed. Additionally, MIDAS would only attempt to generate of single cycle chromosome one time. This was changed so that MIDAS would continuously attempt to generate the chromosome until it had failed 10,000 times.