Add Make-compatible depfile generation (Fixes/Supersedes #41)#64
Open
ijatinydv wants to merge 1 commit intoaradi:mainfrom
Open
Add Make-compatible depfile generation (Fixes/Supersedes #41)#64ijatinydv wants to merge 1 commit intoaradi:mainfrom
ijatinydv wants to merge 1 commit intoaradi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revives and finishes up the depfile generation work originally started in #41.
I built on the original implementation with two main tweaks to make it robust for programmatic use:
process_file()now automatically handles writing the depfile if the--depfileoption is passed, mirroring standard compiler behavior (like GCC's-MMD).ParserorFyppinstance across multiple files would leak stale dependencies from previous runs into the new depfile.Also added a few tests to verify the Make-escaping logic (spaces,
#,$). Let me know if anything needs tweaking!