Open
Conversation
- auth chain ids vs labelled chain ids - add a test that confims this
…gnments-auth-labelling
jandom
added
the
safe-to-test
jnwei
reviewed
Mar 26, 2026
| class TestQueryColabfoldMsaServer: | ||
| """Functional test — hits real ColabFold API (~30-60s).""" | ||
|
|
||
| def test_barnase_with_templates(self, tmp_path): |
Contributor
There was a problem hiding this comment.
I bet we could reuse the ColabFold mmseqs mock itself :
Mock definition: https://github.com/sokrypton/ColabFold/blob/main/tests/mock.py#L109
Usage: https://github.com/sokrypton/ColabFold/blob/9712f2ff262d3977d571919317e06cc96c29cd95/tests/test_msa.py#L7
That would probably be the cleanest way to handle it.
Collaborator
Author
There was a problem hiding this comment.
We would have to vendor it though :/ Not ideal – ColabFold is a very bulk dep to add, i'd rather avoid it
Collaborator
Author
There was a problem hiding this comment.
We've also modified their code a fair bit, i think
Base automatically changed from
jandom/2026-02/fix/chain-template-alignments-auth-labelling
to
main
March 26, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick cleanup of this pretty crucial method and a test
Changes
Related Issues
Testing
Other Notes