docs: add JSONL format to system_variables.md and README.md#583
docs: add JSONL format to system_variables.md and README.md#583
Conversation
- system_variables.md: Add JSONL to CLI_FORMAT valid values, usage examples, and notes (type-aware JSON output description) - README.md: Add --format=jsonl to feature list and --format help text Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code Metrics Report📊 View detailed coverage report (available for 7 days)
Details | | main (bfe804c) | #583 (b50eb77) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 70.9% | 70.8% | -0.1% |
| Files | 78 | 78 | 0 |
| Lines | 7075 | 7075 | 0 |
- | Covered | 5018 | 5014 | -4 |
| Code to Test Ratio | 1:1.3 | 1:1.3 | 0.0 |
| Code | 16419 | 16419 | 0 |
| Test | 21376 | 21376 | 0 |
+ | Test Execution Time | 2m15s | 1m9s | -1m6s |Code coverage of files in pull request scope (83.5% → 81.5%)
Reported by octocov |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the JSONL (JSON Lines) output format, enabling type-aware JSON output for Spanner queries. The changes include updates to the README and system variables documentation to describe the new format and the --format=jsonl flag. A review comment identifies an inconsistency in the README's description of the JSONL format compared to the detailed documentation, specifically noting the omission of ENUM and NULL type handling, and provides a suggestion to align the two.
There was a problem hiding this comment.
Pull request overview
Documents the newly added --format=jsonl output mode so users can discover and correctly use JSON Lines output from the CLI.
Changes:
- Extend
CLI_FORMATdocumentation to includeJSONL, with an example and--format=jsonlnote. - Update README feature list to mention JSONL output.
- Update the README
--formathelp text to listjsonlas a supported value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/system_variables.md | Adds JSONL to CLI_FORMAT valid values, example usage, and notes about JSONL behavior. |
| README.md | Adds JSONL mentions to the feature list and updates the --format help text to include jsonl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/gemini review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The security-enhanced escaping claim applies to HTML/XML/CSV but not JSONL (different encoding story, reference implementation lacked JSONL). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/gemini review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Document the JSONL output format added in #580/#581.
Key Changes
--format=jsonlflag note, and type-aware JSON output description--format=jsonlto feature list and--formathelp textTest plan
make checkpasses