Skip to content

Throwing during request body generation should fail the task#84

Open
guoye-zhang wants to merge 1 commit intoapple:mainfrom
guoye-zhang:request-body-throw
Open

Throwing during request body generation should fail the task#84
guoye-zhang wants to merge 1 commit intoapple:mainfrom
guoye-zhang:request-body-throw

Conversation

@guoye-zhang
Copy link
Copy Markdown
Contributor

The error produced by request body generation should be rethrown, but the error produced when sending the request body should be ignored.

Resolves #83

Questions:

  1. Is throwing the error out of the response stream the right way to handle it?
  2. Any threading concerns with the current approach?

@guoye-zhang guoye-zhang added the 🔨 semver/patch No public API change. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

startWriterTask() discards errors thrown from consuming the httpBody

1 participant